Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pickle and ADIOS2 formatting fixed for OGB dataset #191

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

allaffa
Copy link
Collaborator

@allaffa allaffa commented Sep 9, 2023

The OGB examples was using obsolete functionalities.
I updated the pre-processing for pickle files.
@jychoi-hpc would you mind updating the functionalities for ADIOS to make them match with the new formatting requested?

@allaffa allaffa added the bug Something isn't working label Sep 9, 2023
@allaffa allaffa requested a review from jychoi-hpc September 9, 2023 05:34
@allaffa allaffa self-assigned this Sep 9, 2023
@allaffa allaffa marked this pull request as draft September 9, 2023 05:35
@allaffa allaffa changed the title pickle formatting fixed for OGB dataset pickle and ADIOS2 formatting fixed for OGB dataset Sep 10, 2023
@allaffa allaffa marked this pull request as ready for review September 10, 2023 12:56
@allaffa
Copy link
Collaborator Author

allaffa commented Sep 10, 2023

@jychoi-hpc Thanks for changing the ADIOS2 section of the train_gap.py script.
This PR is now ready to be reviewed by you.

Copy link
Member

@jychoi-hpc jychoi-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good. I tested on my machine and it works.

@allaffa allaffa merged commit ae19713 into ORNL:main Sep 11, 2023
@allaffa allaffa deleted the update_ogb_example branch September 11, 2023 15:30
RylieWeaver pushed a commit to RylieWeaver/HydraGNN that referenced this pull request Oct 17, 2024
* pickle formatting fixed for OGB dataset

* update on adios

---------

Co-authored-by: Choi <choij@ornl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants